Fylo dark theme landing page

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, there, Kevin Canlas! 👋

  Nice job on this challenge! 👍 Your solution looks good and responds nicely! 👏

  In addition to emestabillo's helpful feedback, I just suggest adding a max-width to the header of the page so that it doesn't become too wide on extra-large screens. 😉

  You're doing great and improving with each challenge! 🙌

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Kevin Canlas•225

  @kvncnlsPosted almost 4 years ago

  @ApplePieGiraffe Thank you APG! I'll work on that!

  0
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  Hey Kevin, looks pretty good! No responsive issues. Here are a few things I saw:

  • Missing anchor tags for navbar items

  • Buttons and links typically have hover states for UX. Those on the footer which have it, could use transitions to make the change in state smoother. Phone and email - better as links too.

  • I'm curious: Why was id used in the sign-up section? It's currently not used for JS or page scrolling

  • BEM naming: I think it's better to keep it at two levels deep. It also got a little verbose, for example footer__container__main__logo . Not sure if you were going for a modifier there, but if it were me, I might just keep it at logo.

  • For custom error messages, you'd definitely need to add JS. Insert the error message in your html and hide it with visibility or opacity and reveal when needed. This would ensure there would be no shifting of adjacent elements when the error message is shown, vs inserting it at the event of an error.

  Hope this helps :-)

  1

  ---

  

  Kevin Canlas•225

  @kvncnlsPosted almost 4 years ago

  @emestabillo Thank you!! I have to work on all of these things, thank you so much!!

  1
• 

  Dave Hillman•830

  @dhillman1989Posted almost 4 years ago

  Great effort pal. not looking at the code, but the page is very close to the design minus some sizing issues. Well done.

  1