Design comparison
Solution retrospective
I think what I have written is not the best way to do this, and an actual layout could be much better than just using flex everywhere. but I think it was fine for such small templates
I do have a doubt on overflow hidden and does it cause any issues in acessibility or what. Should I also make the icons <button> tags and cursor pointer?
Community feedback
- Account deleted
Hello there 👋! Congratulations on completing the challenge and submitting a great solution! 🎉
As I was reviewing your code, I noticed an opportunity to improve the accessibility and organization of your webpage by implementing semantic markup. Currently, there is a non-semantic <div> element that's generating an accessibility error related to the lack of landmarks on the page.
To resolve this, I recommend using a semantic <main> element instead of the <div> element. Landmarks are essential in defining the major sections of your page, and using generic elements like <div> or <span> can create confusion and accessibility issues. By using the <main> element, you'll convey the page's primary content and enhance the structure and accessibility of your page.
I hope you find this recommendation helpful. Please let me know if you have any questions or concerns. Keep up the great work and happy coding! 😄
0@chill31Posted over 1 year ago@ktra99 I think for the template it would be fine so I ignored a few accessibility issues such as semantic elements Still, thanks for the comment, I also ignored this issue a few times in some major websites I have made.
guess I go need to fix them
0 - @0xabdulkhaliqPosted over 1 year ago
This comment was deleted over 1 year ago
0@chill31Posted over 1 year ago@0xAbdulKhalid I just ignored it because it was a template design, I am going to make sure I follow such rules in web designs I make
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord