Fyle Solution Challenge

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Hey Shahin, congrats on submitting your first solution! You've done a really good job. Here are some thoughts after taking a look at your code:

  • You're using position: absolute; on the img elements. I'd recommend taking a look into Flexbox and CSS Grid as opposed to using position: absolute; for layout purposes. This also goes for using float too. Grid and Flexbox are really powerful for laying out web pages and are a much better tool for the job.
  • Also, I'd recommend avoiding IDs as CSS selectors. They can't be reused on the page and they're overly specific. Instead, I'd stick to class, attribute, pseudo and type selectors.
  • Have a go at resolving the accessibility issues. Building accessible websites is a key part of being a front-end developer.

  I hope these pointers help. Keep up the great work!

  0

  ---

  

  Shahin•95

  @ShahinthecoderPosted almost 5 years ago

  @mattstuddert Thank you very much for your feedback. I will check these points again. I appreciate your help.

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @Shahinthecoder you’re welcome!

  0