Design comparison
SolutionDesign
Solution retrospective
This is the first Junior challenge that I have done. I would like feedback concerning how I used the DOM to select the interactive elements. This is pure vanilla JavaScript, no libraries were used.
Community feedback
- Account deleted
Hi there 👋
Congratulate on finishing your project 🎉. You did a great job 🔨
I give some suggestions that I hope help you take your project to the next level 📈.
- In your javascript if you don't change the values instead of letting using const is better
- TIP 🎁* There is also the great naming tip of dom elements. Like if it is a button name it like
submitBtn
we also use inputs so call themtipInput
and if you select the just text you can name it likeheadingLabel
. It helps a lot especially with 50-100 selected dom elements
Happy coding ☕
Maqsud
Marked as helpful0@oinsurPosted almost 3 years ago@maqsudtolipov Thank you for your feedback! I will consider renaming my dom elements in future projects. Great suggestions!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord