Great work indeed. Well done. The mobile and desktop view is awesome.
- take another look on medium devices from about 465px screen size - the navigation does not present well , some elements are sitting on top of others.
- img must have alt text for accessibility.
- i noted that the nav has been repeated twice (with one dedicated for mobile) - my opinion is to have one navigation that you can display and move around with css
happy coding
@thedev966
Posted
@ChamuMutezva Hey, thanks for your suggestions! Yeah, I know I need to add another breakpoint for medium sized devices to fix that overflow problem with my navigation. I have probably forgot to add alt to my images, but I know in production based websites, it is mandatory to include that as well. Actually, I had a plan to keep only one navigation and only customize it with media queries for mobile phone screens but there was a problem. On mobile phone screens, header changes drastically and I thought it would be easier to make a separate navigation for only mobile phones. Maybe, it is not a perfect way to do it but it worked well even though I personally always try to reuse the same code over repetition.