@AdrianoEscarabote
Posted
Hi Aviral, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Read more, he is not confirming a form, or something like, it will be redirected to another page, to read more about!
To resolve do this:
<a href="/">Read More</a>
avoid using px, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to rem
The rest is great!
I hope it helps... 👍
Marked as helpful
@Akunamo
Posted
@AdrianoEscarabote
Hey Adriano Thanks for the feedback!
Yeah I did thought about that but i was not totally sure when i wrote that,I thought we use a to redirected to other page but what if that article is on the same page somewhere below because its a news site, then i thought buttons are used for interactions so thats why i used button.
Correct me if i am wrong
But now that i think about it even if it does not redirect user to other page we can still use the a for scrolling down if that article is in the same page.
Oh and about that px i only used px to set font-size on on body as
body { font-size: 15px ; } and used rem in the rest of code.
I can remember Kevin Powell did used rem for font-size on body as well But i don't know why, and now when i checked this project on my mobile and use desktop-mode the text is too big and the navbar is broken(its broken because of large font-size) is it because of that font-size in px on body.
Thanks for the feedback though i greatly appreciate it, Have a good day
@AdrianoEscarabote
Posted
@Akunamo Yes, with the a tag we can make it point to another part of the code! I've seen some sites that have a back to top button these buttons are made with the a tag.
