Fully responsive mobile/PC version, SCCS, Javascript
Design comparison
Solution retrospective
Any feedback is welcome. ;)
Community feedback
- @A-amonPosted over 3 years ago
Hey! Great job~ It would be better if you don't set the styles directly in JS. Instead, you can add a class. For example, adding .error class to the input fields with error and set the styles in your css. It'd be nice to know if the button is clickable by adding a hover state to it and set cursor:pointer;
1@SvobyyyPosted over 3 years ago@A-amon Thank you very much, I forgot and didnt notice the cursor pointer on the button. Regarding the classes, Im normally using them with javascript and I agree that it would be easier to use classList.add and .remove, when Im thinking about it I dont know why I didnt use them :D. Again thank you very much for your helpful feedback.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord