Design comparison
SolutionDesign
Community feedback
- @mattstuddertPosted almost 5 years ago
Hi Prem, nice work on this challenge your solution looks really good! Here are a few recommendations after taking a look at your code:
- You've currently got 5
h1
elements, but no other headings. I'd recommend having just a singleh1
to mark the page title and then use other heading levels to create a content hierarchy. - Try to use the
alt
text in theimg
tag as a description of the image. Youralt
for the logo is just "logo" and the main illustration is "header image", which adds no context to what the image is. In these instances,alt
text like "Huddle" and "Illustrative mockups of desktop and mobile screens" would add more context. - The social icons would be clickable links if this were a real landing page, so I'd put anchor tags around each icon.
You've done a really good job on this. Keep up the great work! 👍
1 - You've currently got 5
- @prem1835Posted almost 5 years ago
Thank you Matt for your suggestions I will work on the all of them. I really appreciate your feedback ♥️ Thank you
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord