Fully responsive, HTML, CSS.

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted over 3 years ago

  Hey @Stygan 👋🏻

  I have a couple of suggestions for the project.

  • First, for the illustration, add aria-hidden="true”, because it's for decoration. You can read more about aria-hidden here. Like so:

  <img src="./images/illustration-mockups.svg" alt="" class="illustration" aria-hidden="true”>
  

  • Next, the social links, could be in ul and each li could have <a> tag that can either take to empty pages of the websites accordingly or just point to nowhere href="#". This would be semantically correct.
  • Also, the icons should have aria-hidden="true" and if you choose to implement my suggestion, make sure to add aria-label for the <a> tags that would have the names of the icons, such as, aria-label="facebook" and like so for the other two icons.
  • Lastly, I won't go into many details about resetting CSS, but I'll leave this cool article here, which will make more sense than my brief explanation.

  I hope this was helpful 👨🏻‍💻 all in all, you did a great job, especially with the animation, well done Cheers 👾

  Marked as helpful

  2

  ---

  

  Stygan•260

  @JavierMussoPosted over 3 years ago

  @kens-visuals Thank you so much! Cool tips, will be fixing and reading those articles. Thanks for taking the time to give feedback.

  0

  

  P

  Ken•4,915

  @kens-visualsPosted over 3 years ago

  @Stygan you're welcome, glad to be helpful 😇

  0