Design comparison
SolutionDesign
Solution retrospective
Hey everyone, I think I'm getting a hang of this. Any advice is still appreciated :>
Community feedback
- @SzymonRojekPosted almost 4 years ago
Hi ta-zzz,
Well done :D
I have checked your HTML structure, a few tips from me:
- this is a single page component so good that you have added the h1 tag, but is should be only once => in this case you can create h1 with two spans inside (main-heading and sub-heading);
- I think the main component is below the header so you could use the main tag over there;
- alt text can be empty alt=" " because icons are only decorative so they can be ignored by assistive technologies, such as screen readers;
- RWD: check your project by the inspector in your browser => you can create layout for tablets => two rows with two boxes each, it will be better visually (the component will not be so tight on smaller screens) and then you can implement this desktop design pattern;
- add max-width to the container;
Greetings :D
1@SzymonRojekPosted almost 4 years ago@ta-zzz
Thanks. I’d recommend reading MDN and W3C documentation about headings h1-h6 => that’s very important subject.
Have a great coding time 😃
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord