Fully responsive E-Commerce Page HTML CSS JAVASCRIPT

Community feedback

• 

  S MD suleman•3,530

  @sulemaan7070Posted over 1 year ago

  hey 😄marvin, congratulations on completing the challenge... here are a few tips to make your site better.

  1.when I click on add to cart button after adding the items the counter should become zero.

  2.The span element named as .item should have specific width so that it won't affect the whole page when clicking on + or -...

  3.Add an overlay in the background when mobile-menu is opened.. more about the overlay here📚

  4.Add box-shadow to the add to cart button to match it with the design..

  hope that helps, happy coding💯🔥👍🏻

  Marked as helpful

  0

  ---

  

  marvin•340

  @33marvs33Posted over 1 year ago

  @sulemaan7070 thank you for this wonderful tips. i will edit my code hehe

  1

  

  S MD suleman•3,530

  @sulemaan7070Posted over 1 year ago

  @33marvs33 it's a pleasure helping you buddy😄

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the element <div class="attribution"> the with semantic element <footer> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  marvin•340

  @33marvs33Posted over 1 year ago

  @0xAbdulKhalid thank you for the suggestion it helps me improved my coding

  0