Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fully responsive E-Commerce Page HTML CSS JAVASCRIPT

marvinβ€’ 340

@33marvs33

Desktop design screenshot for the E-commerce product page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


What did you find difficult while building the project? On the responsiveness of the website Which areas of your code are you unsure of? uhhm in the styling

Community feedback

S MD sulemanβ€’ 3,530

@sulemaan7070

Posted

hey πŸ˜„marvin, congratulations on completing the challenge... here are a few tips to make your site better.

1.when I click on add to cart button after adding the items the counter should become zero.

2.The span element named as .item should have specific width so that it won't affect the whole page when clicking on + or -...

3.Add an overlay in the background when mobile-menu is opened.. more about the overlay hereπŸ“š

4.Add box-shadow to the add to cart button to match it with the design..

hope that helps, happy codingπŸ’―πŸ”₯πŸ‘πŸ»

Marked as helpful

0

marvinβ€’ 340

@33marvs33

Posted

@sulemaan7070 thank you for this wonderful tips. i will edit my code hehe

1
S MD sulemanβ€’ 3,530

@sulemaan7070

Posted

@33marvs33 it's a pleasure helping you buddyπŸ˜„

Marked as helpful

0
Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage
  • So fix it by replacing the element <div class="attribution"> the with semantic element <footer> in your index.html file to improve accessibility and organization of your page.
  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
  • They convey the structure of your page. For example, The <footer> typically contains information about the author of the section, copyright data or links to related documents.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

marvinβ€’ 340

@33marvs33

Posted

@0xAbdulKhalid thank you for the suggestion it helps me improved my coding

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord