Submitted over 1 year ago
Fully Functional Calculator App with Toggle Themes
@CodingTimmyeth
Design comparison
SolutionDesign
Solution retrospective
What I found difficult about this app was figuring out how I am going to implement the different toggle themes. My solution was to create an object with a different key, based on the dotPosition, and changed the color accordingly.
Areas in my code are how can I refactor it to be clean and easily understandable.
Where in my code can I implement best practices (mainly in the App.jsx and CalcNumbers.jsx)?
Community feedback
- @JaneMorozPosted over 1 year ago
Hey! Congrats 🎉 This is a great solution to the challenge!
The only things I've noticed:
- A little style issue: if the screen's height is less than 730px, background-colour doesn't fill the whole screen
- Also I can put operators one after another (for example 10+/2) and it gives me an error
Keep it up! And good luck 🍀
1@CodingTimmyethPosted over 1 year ago@JaneMoroz Thanks for the Feedback! Will adjust and update the code ! :)
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord