@Radexman
Posted
Hey there! I’ve checked your code and if you don’t mind I will give you some feedback :)
First of all the class naming convention, we typically want to name our id’s and classes in a semantic way. Don’t get me wrong, “right” and “left” are fine but when other dev will be reading our code he might have a little headache, it is good practice to name our classes in short self-explanatory way eg. left - “img-box”, right - “product-description”. There is no need to add a class to our button if we have only one button on our page, just use the button selector.
In your code h2 appears before h1, when using headings we follow a so called hierarchy, we want to start from h1and move our way to h6 and if the styling is not how we imagined it, just change it in css. Here is some good resource on that:
https://www.contentkingapp.com/academy/headings/
Hope you find it somewhat useful, good luck on next projects!
Happy Coding!
Marked as helpful
@36atharva
Posted
@Radexman Thankyou for your suggestions! Will remember these in future :)
