Full Responsive Landing page with HTML,Scss,vanila JS , Bootstrap

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  Hi @shahabs789 nice work on this one ! 👏 I'm trying this at the moment and it's got some nice tricky bits in it. Here's some thoughts you might like to consider:

  1. There's some HTML issues - notably, don't forget that every id on a page must have a unique value

  2. To keep the HTML valid you can't put a 'block' level element inside an inline element (you could just swap, your 'li' and 'a' tags - I think this is the way most people do it)

  3. When I hover over the photo links the text turns dark. This makes it not really readable - this should be fairly easy to fix?

  4. Lastly, when the hamburger menu is open the navigation goes off the end of the black background, so the 'support' link appears to be missing.

  The site responds very nicely though and looks good at small screen sizes, and I like the nice touches you have added with transitions and things!

  If you want to think of taking your code to the next level, I would look into how you can make things more consistent across the page - using utility classes to add consistent padding or margin could help with this.

  I hope this helps and keep up the great work!! 🙌 Cheers 👋

  1

  ---

  

  shahab shafie•70

  @Shhb-Coder-1999Posted over 3 years ago

  Dear @dwhenson Tnx very much for your effective suggests ... 🙏 they help me to improve my skills . You're right . I try to fix them .🙌

  0