Full component based design using React and Styled Components
Design comparison
Solution retrospective
Comments and critiques welcome - first time using styled components...
Community feedback
- @mattstuddertPosted over 4 years ago
Awesome work on this challenge. Your solution looks great and scales down well to mobile! How did you get on with Styled Components? I really like them and find they work perfectly paired with React.
It's great to see you using the
themeProvider
for reusable styles. One quick thing to note is that you're setting styles in a few places usingelement.style.
. With Styled Components you can pass values in as props and handle it in your styles. This will ensure inline styles aren't added to elements unnecessarily.Also, there are a few really small things like adding
cursor: pointer
to interactive elements and hooking up the "Contact Us" call-to-action in the "Ready to get started?" section.Awesome work though, it matches up to the design nicely! π
0@foolishsailorPosted over 4 years ago@mattstuddert
Got a bit lazy with some inline styles βΊοΈ
..will pull them into SC and sort out the other tips.
Great feedback thanks!!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord