Submitted over 3 years ago
front-end-mentor-template-3 using HTML, CSS
@AbdelrahmanAbdelwahed
Design comparison
SolutionDesign
Solution retrospective
please feedback my code
Community feedback
- @vanzasetiaPosted over 3 years ago
👋Hi Abdelrahman Abdelwahed! My name is Vanza!
I have some feedback for your code:
- I would recommend to use shortcut for this stuff, for instance on
margin
:
body { font-family: "Bai Jamjuree", sans-serif; font-size: 18px; margin: 0; }
Instead of this:
body { font-family: "Bai Jamjuree", sans-serif; font-size: 18px; margin: 0px 0px 0px 0px; }
As you can see, you can get the same result with less code. Also you may notice that
0
does not need any unit since0px
=0
.- Try to fix those issues from Frontend Mentor report. It will make sure that you write a valid html.
That's it! Hopefully this is helpful!
Happy Coding!
0 - I would recommend to use shortcut for this stuff, for instance on
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord