Design comparison
Solution retrospective
I learned new concepts
What challenges did you encounter, and how did you overcome them?I faced to center the image
What specific areas of your project would you like help with?I like to center things
Community feedback
- @danielmrz-devPosted 8 months ago
Hello @shivadhanush1216!
Your solution looks great!
I have a suggestion for improvement:
π Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.
πAlso, instead of using
<div>
as list items, it's recommended to use semantic HTML elements like<ul>
and<li>
for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.Example:
<ul class="list-container"> <li><a href="#">Github</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> ... </ul>
By using
<ul>
and<li>
, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.I hope you find this helpful!
Keep up the excellent work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord