Frontend-Mentor-QR-Code

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  The `width: 100vw` property for 'body' element is not necessary. it will take the full width of the page by default.
  
  Use `min-height: 100vh` instead of `height: 100vh. Setting the `height: 100vh` may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
  

  ---

  • Example: if we set height: 100vh then the bodywill have100vhheight no matter what. Even if the content spans more than100vh. But if we set min-height: 100vhthen the body will start at100vh, if the content pushes the bodybeyond100vhit **will continue growing**. However **if you have content that takes less than100vhit will still take100vh` in space**. .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  HTML

  In order to fix the accessibility issues:

  • You need to replace <div class="wrap"> with the <main class="wrap"> tag and <div class="attribution"> with the <footer class="attribution"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.

  CSS

  • If you want to use the recommended color for the background, you can use this style:

  body {
      background-color: hsl(212, 45%, 89%);
  }
  

  Hope I am helpful. :)

  Marked as helpful

  0