@correlucas
Posted
👾Hi Atanu Malik, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!
Nice solution and nice code! I can see that you paid a lot of attention to your code/design. If you don’t mind I’ve some tips for you:
1.Use <main>
instead of <div>
to wrap the card container, its better to use <main>
in this case because you’re indicating that’s the main block of content of this page and also because <div>
doesn’t have any meaning, it's just a block element.
2.Something I've noticed in your code is that in many occasions you've added some <div>
to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div>
or <main>
if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:
<body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
✌️ I hope this helps you and happy coding!
Marked as helpful
@AtanuMalik
Posted
@correlucas Thanks for the feedback. I will keep that in mind. I am learning so much with every challenge and enjoying it as well.