Frontend-Mentor---Profile-card-component with flexbox

Community feedback

• 

  Martin de Boer•50

  @martindb1988Posted about 3 years ago

  Great job, but a few suggestions. Naming your css file css.css is rather weird also in terms of clean code your css has tabs and no tabs.

  Try to be more consistent with that, clean code makes the code better readable for other devs.

  2

  ---

  

  Joe sherbini•20

  @yousefshrpinyPosted about 3 years ago

  @martindb1988 how can I write clean code that is the main problem I'm facing recently

  1

  

  Martin de Boer•50

  @martindb1988Posted about 3 years ago

  @yousefshrpiny , There are several resources out there to look at :)

  http://getbem.com/ ( Block Element identifiers )

  And also here is something interesting about DRY and KISS. https://dzone.com/articles/software-design-principles-dry-and-kiss

  1
• 

  CyrusKabir•1,885

  @CyrusKabirPosted about 3 years ago

  hello my dear friend ♥ you did good at all but here some advice :

  • go and search about this term "css centring ways" learn them good
  • i am looking your code and i see you use before pesudo element for just adding a line to card !! easily you can do it by adding border-top in your footer card

  1
• 

  Gia Phong•80

  @giaphong992Posted about 3 years ago

  Great work here mate. But I think you should replace the translate with margin 0 auto to center the div horizontally. For the vertical, you might want to use translate Y(50%) to center the card. However, you did this challenge better than me though. Cheer

  1