@fritzadelbertus
Posted
Hello @Ripra87. First of all, congratulations on finishing this challenge! Here are some few suggestion I can give:
-
The rounded border problem, to implement better rounded border use units in pixel. Using percentage in
border-radius
is useful to create ellipse looking element but not recommended to create rounded borders. try changing theborder-radius:10%
toborder-radius:20px
, it should solve that problem. -
I see your css styles haven't implement
display: flex
ordisplay: grid
yet. I recommend you start using them. Margin and padding is useful to create spaces between element but flexbox and grid are powerful tools to create complex layouts.
I hope it's helpful and happy coding!
Marked as helpful
@Ripra87
Posted
@fritzadelbertus Hi Fritz and thank you so much! i changed the borders using px instead of % and now it works! About the dispaly, i still never used the grid, but i used display flex in this project in the body and in the main to center all the components (center for the body and column for the main) and also inside the plan infomations (where is the link change) with the row, should have i used it somewhere else? Thank you )
@fritzadelbertus
Posted
@Ripra87 In the card content, I see you used margins to space the top and bottom part of the content. Instead, you can wrap the whole content in a <article>
tag and create spacing between the <article>
and the outer layout. The spacing between plan-info and change div can also be implemented using flex and justify-content:space-between
for a more responsive result.
Marked as helpful