front-end-mentor-blog-preview-card using HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted 7 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • "I would like to learn more about code optimisation, readability", I would like to notify about the issue with using height property first.

  ---

  • You need to use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Bernardo Poggioni•5,280

  @R3ygoskiPosted 7 months ago

  Hello @Mys1337, congrats for conclude your project.

  Regarding code optimization, I believe you are referring to HTML, correct? So, concerning the optimization of your HTML structure, what you can do is use semantic tags like <main>, <header>, <article> and so on. Most of these semantic tags behave like <div>. They are important as they aid in the accessibility and SEO of your project. I'll leave a link here for more information: W3School - Semantic HTML.

  I noticed a few things that seemed a bit odd, for instance, this snippet:

  <a href="#">
    <h1>HTML & CSS Foundations</h1>
  </a>
  

  It would be more correct for the <h1> to encompass the <a> rather than the other way around. There's also another case regarding the <span> within <h2>, I honestly don't think it's necessary. It could simply be <h2>Learning</h2>, and then you could change <h2>Published 21 Dec 2023</h2> to <p> or even <time>.

  Now, to further improve readability, I would recommend using the BEM methodology, and if you ever intend to use any CSS preprocessor, BEM will be of great assistance.

  And again, congrats, if something I said was unclear, please comment below, and I will try to help in the best possible way.

  Marked as helpful

  0