Frontend-Mentor

Community feedback

• 

  Daniel Martinez•80

  @danieljmlPosted about 3 years ago

  @MarlonPassos-git Thank you for your advice and comments. I'll pay attention to them. I appreciate that you have taken the time to view my code.

  0
• 

  Marlon Passos•940

  @MarlonPassos-gitPosted about 3 years ago

  hello Daniel, congratulations on your first finished FEM project. I particularly liked your design, it was flexible and the transparency effect of the social card animation was really cool. Now some points I would like to comment so you can improve

  • the button should be inside a <button> tag to be accessed by the keyboard

  • Slightly increase the size of social media icons

  • Instead of using paddin to space between social network icons, you could have used the gap property to do this, it's much more flexible.

  • Very strange your approach of using a single section exclusively to place a background image, in this you have two approaches. Either use an <img> tag or place the image as the background of a <div>. The image should be inside the artigle tag.

  • The image in the mobile version is smaller, maximum 200px, this way it doesn't take the focus off the text

  0