Skip to content
Submitted over 2 years ago

Frontendmentor QR Code Card

Mohamed Saafan•10
@MohamedSaafan
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

have I named the classes correctly? have I used the right units? have I used HTML5 Semantic tags correctly? any hints about the structure of the CSS in general?

Community feedback

  • Ismail•230
    @itbeginswithiPosted over 2 years ago

    Hi Mohamed, congrats on your finishing your first project on Frontend Mentor!

    Yes, you used the right units, your HTML5 semantic tags are good too.

    The structure of css is alright except for the way you named some of your classes using the BEM method, for instance, I would have named the card__heading class as card__body_heading since it is a direct child of the card__body class, this would come in handy especially when using scss.

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord