frontend-mentor challenge - 1

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello 👋. Congratulation on successfully completing your first challenge 🎉 ! !

  I have some recommendations regarding your code that I believe will be of great interest to you.

  • The link of the repository is incorrect, it should be https://github.com/Aguslei/qr-component, you can update the link of the repository in this solution to redirect the user to the correct repository.

  HTML 📄:

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">.

  • The text Improve Your Front-End Skills by Building Projects is considered a heading element (h1).

  Alt text 📷:

  • Alt text should provide a clear and accurate description of the image's content or purpose. In this challenge, if you scan the QR code you will be redirected to the "frontendmentor.io" website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Source 📘.

  • Use min-height: 100vh instead of height: 100vh. The height property can cause your component to be cut off on small screens, such as a mobile phone in landscape mode. screenshot-imgur (landscape mode)📸

  • The width: 100vw property in the .main tag is not necessary. This will create a horizontal scrollbar on some devices.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1