P
Srijan Manandhar• 450
@srijanss
Posted
- Your solution includes semantic HTML
- Keyboard navigation is not working, you can look into tabindex attribute or keydown event for different interactive elements in your app
- Layout looks good on different screen sizes, except some mid breakpoints where layout squeezes too much. You can look into CSS grid and flexbox layout for easy layout of components. And also you can use breakpoints like 550px for mobile, 768px for tablet and 1200px for desktop in this case as content width is 1160px.
- You have used Vue3 to build this app, so the code is nicely structured , readable and resuable
- Some of the layout and fonts doesn't match with the design, so the solution differ a bit from the actual design
Good work.
0
