Frontend Profile QR code component Website

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Awesome work with this one! Webpack can be confusing sometimes and you did well implementing it here. Viewing your solution, everything is great, I think you should consider the following as well..

  • Wrap the card with specific tag like main and attribution with footer tag for readability.

  Overall you did a great job and Keep it going! Cheers!

  Marked as helpful

  1

  ---

  

  pascal de creator•120

  @pascall-de-creatorPosted almost 3 years ago

  @RioCantre

  Thank you for the suggestion... I will be sure to implement them in my next commit. :D

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job pascal de creator

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  Keep up the good work!

  1

  ---

  

  pascal de creator•120

  @pascall-de-creatorPosted almost 3 years ago

  @Crazimonk

  Thanks, your support is much appreciated. I will be sure to update the solution in my next update :D

  1