@owocoded
Posted
Why not try to give your img class in your html and do the same in your css. Something like this; .img{ border-radius: 10px; } I hope this is helpful. Happy coding.
I wasn't able to add border radius to the top part of the qr code(don't know the reason). While viewing the website in various sizes as because the card's position was changed to relative it comes out of the container.
Would be great if someone could check out the code and help.
@owocoded
Posted
Why not try to give your img class in your html and do the same in your css. Something like this; .img{ border-radius: 10px; } I hope this is helpful. Happy coding.
@jakegodsall
Posted
Hi, some of the styling from bootstrap is overriding the style on the img tag for the top-left and top-right border radius.
I've not used bootstrap yet but inspecting your component using the Chrome dev tools it seems that
.card-img, .card-img-top {
/border-top-left-radius: calc(0.25rem - 1px);
border-top-right-radius: calc(0.25rem - 1px);
}
from
[email protected]/scss/mixins/_border-radius.scss
is causing the troubles.
Hopefully someone with a bit more knowledge can provide more insight on this.
@PhoenixDev22
Posted
Hi HIMANSHU,
Congratulation on completing this frontend mentor challenge. Excellent work! I have some suggestions regarding your solution:
<main>
landmark to wrap the card . HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology. <h1>
. In this challenge , as it’s supposed to be a part of a whole page, you may use<h1>
with sr-only
class hidden visually and present for assistive tech users. Then you can use <h2> instead of <h5>QR code to frontend mentor
not describes the image.In order to center the card on the middle of the page , you can use the flexbox
properties and min-height: 100vh
for the <body>
add a little padding to the body that way it stops the card from hitting the edges of the browser without any need for position: absolute or relative of the container and the card.
Overall, your solution is good. Hopefully this feedback helps.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord