Skip to content
Submitted about 2 years ago

FrontEnd Practice

HIMANSHU•10
@HIMU-2001
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I wasn't able to add border radius to the top part of the qr code(don't know the reason). While viewing the website in various sizes as because the card's position was changed to relative it comes out of the container.

Would be great if someone could check out the code and help.

Community feedback

  • Yusuf Babatunde•150
    @owocodedPosted about 2 years ago

    Why not try to give your img class in your html and do the same in your css. Something like this; .img{ border-radius: 10px; } I hope this is helpful. Happy coding.

    0
  • Jake Godsall•1,390
    @jakegodsallPosted about 2 years ago

    Hi, some of the styling from bootstrap is overriding the style on the img tag for the top-left and top-right border radius.

    I've not used bootstrap yet but inspecting your component using the Chrome dev tools it seems that

    .card-img, .card-img-top {
    /border-top-left-radius: calc(0.25rem - 1px); 
    border-top-right-radius: calc(0.25rem - 1px);
}

    from

    [email protected]/scss/mixins/_border-radius.scss

    is causing the troubles.

    Hopefully someone with a bit more knowledge can provide more insight on this.

    0
  • PhoenixDev22•16,950
    @PhoenixDev22Posted about 2 years ago

    Hi HIMANSHU,

    Congratulation on completing this frontend mentor challenge. Excellent work! I have some suggestions regarding your solution:

    • You should use <main> landmark to wrap the card . HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
    • Page should contain <h1>. In this challenge , as it’s supposed to be a part of a whole page, you may use<h1>with sr-only class hidden visually and present for assistive tech users. Then you can use <h2> instead of <h5>
    • In my opinion, the image is an important content. The alternate text should indicate where the Qr code navigate the user: like QR code to frontend mentor not describes the image.

    • In order to center the card on the middle of the page , you can use the flexbox properties and min-height: 100vh for the <body> add a little padding to the body that way it stops the card from hitting the edges of the browser without any need for position: absolute or relative of the container and the card.

    • Consider using rem and em units as they are flexible, specially for font size better to use rem. If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs.Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
    • Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.

    Overall, your solution is good. Hopefully this feedback helps.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord