Frontend | Perfume Product

Community feedback

• 

  Madiha Khan•420

  @madkn1311Posted over 2 years ago

  Hello Ammar,

  You designed the card really well. :)

  To center your card you should do the following:

  min-height is the best option as it will change when needed(i.e enable responsiveness). Plain height property won't allow responsiveness.

  body{
  min-height: 100vh;
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  }
  
  

  Marked as helpful

  0

  ---

  

  Muhammad Ammar•50

  @ammarqureshi120Posted over 2 years ago

  @madkn1311 Thankyou! I will improve this.

  0

  

  Madiha Khan•420

  @madkn1311Posted over 2 years ago

  @ammarqureshi120 you're welcome..!!

  0
• 

  AlwinJun•230

  @AlwinJunPosted over 2 years ago

  Mr.Ammar you can put your main content inside of main tag for better accessibility or put a role attribute with a value of main in your card-container element <div class="card-container" role="main">. By the way nice job.

  Marked as helpful

  0

  ---

  

  Muhammad Ammar•50

  @ammarqureshi120Posted over 2 years ago

  @AlwinJun Thankyou! For Your Feedback.

  0