Frontend Mentor - Stast preview card

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Yakeru! 👋

  Congratulations on finishing this challenge! 🎉

  I notice something interesting in the script.js. Are you using it to compare the site with the design?

  Currently, I can't review the CSS because it is minified. Also, opening every single Sass file to review the CSS is really hard work. So, I recommend providing the "un-minified" assets so that people can review your code.

  Now, for the feedback.

  • For the statistic, I recommend making it as a list. If the site has no styling then it is more likely to be a list.
    • 10k+ companies
    • 314 templates
    • 12m+ queries
  • The values__header should not be a h3. The content below it is too small. Think of the HTML document as a normal document file. So, h1 as the main title, h2 as the sub-title, etc. So, I recommend using strong or span with bold styling.
  • I would recommend swapping the figure tag with div tag. The only reason to use figure is if you need to include a figcaption. Otherwise img tag is fine.
  • The image is a decorative image. So, leave the alt="" empty. This way, it will make sure that the screenreader users won't have to listen to unnecessary page content.

  That's it! Hope this helps.

  0