Frontend Mentor - Social proof section solution, Finish

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Marcin! 👋

  Congratulations on finishing this challenge! 🎉 It's great that you are writing the styling with the mobile-first approach! Also, good job on leaving the alt empty for all star icons! Well done! 👍

  However, there are two things that can be done better.

  • Firstly, There should not be text in span and div alone; instead wrap the text with a meaningful element.
  • Secondly, wrap the .box__person--description with blockquote element. It is a good use case to use it because the text is a quotation.

  I'm not sure that telling the user the orientation for the photo would be beneficial information, especially in this case since all the photos are rounded. So, do you have any good reasons for it?

  1440px for the desktop layout is too late. It makes me think that you use the sizes on the style-guide.md. For your information, the sizes have nothing to do with the media queries. They are telling you that "this is how your website should look like at these screen sizes". As frontend developers, we should keep making your website looks good in between those screen sizes.

  I hope this helps! Keep up the good work! 👍

  Marked as helpful

  0