Skip to content
Submitted 4 months ago

Frontend Mentor social linktree challenge solution

Abiola Oloyede•40
@burnacode
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

completing the challenge

Community feedback

  • Dylan de Bruijn•3,230
    @DylandeBruijnPosted 4 months ago

    @burnacode

    Hiya! 👋

    Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

    Things you could improve ✍️

    • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

    • The attribution text is a bit hard to read, I suggest using a different color.

    • To my knowledge the <main-body> tag is not an official HTML tag. A <body> with a <main> inside should be enough in your case. You can remove the <main-body> tag.

    • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

    • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

    • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

    • Try using using relative CSS units like rem and em they make your layout more adaptable.

    • Try putting your links in a list (ul) to make your code more semantic.

    I hope you find my feedback helpful! 🌟

    Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

    Happy coding! 😎

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord