Frontend Mentor - Social links profile using Flex & Grid

Community feedback

• 

  P

  Justin Connell•720

  @justinconnellPosted 10 months ago

  Good use of those sleepless nights!

  Your solution looks great especially given you should have been sleeping.

  Looking at the live preview everything looks good on different screen resolutions.

  Looking at the code:

  • The code is well structured and readable
  • Great use of naming for the CSS classes

  The only suggestion I have in terms of improvements is to try using semantic HTML to markup components - you could view a social card as an ‘article’ that has a ‘header’, some ‘content’ and ‘footer’ section in most cases (expect there's no footer in this design), then the semantic markup could be:

  <article>
    <header>
        /* heading content here */
    </header>
    <section>
        /* main content here */
    </section>
    <footer>
       /* footer content here */
    </footer>
  </article>
  

  Overall I like your 'style'

  I hope you find this useful, keep on coding, but get some sleep sometime ;) !

  Marked as helpful

  1

  ---

  

  John Carruthers•310

  @techyjcPosted 10 months ago

  @justinconnell thanks! I will update with the changes you suggested.

  1
• 

  John Carruthers•310

  @techyjcPosted 10 months ago

  Updated the design with the suggested changes.

  0