Skip to content
Submitted almost 3 years ago

Frontend Mentor | QR Code | HTML CSS

Nick•40
@FrontEndNick2022
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

If anyone every checks this, please let me know what I could have done to minimize the code. I'm sure I go about things in a long winded way, when I can write less and get he same results.

Thanks,

Community feedback

  • Rio Cantre•9,690
    @RioCantrePosted almost 3 years ago

    Hello there! Good job with this one. Looking at your solution I think you should considered the following...

    • Add the background-color: var(--bg-main); inside the body tag to give the full width background color
    • Remove the background-color in the wrapper rule set
    • Wrap the wrapper with main tag for readability

    Other than that, your good to go. Complement for the CSS properties, I like how you utilized it. Keep up the good work!

    Marked as helpful
    1
    Nick•40
    @FrontEndNick2022Posted almost 3 years ago

    @RioCantre

    Thank you for the feedback, your time and comments are much appreciated

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord