Frontend Mentor | QR code component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Israel John,

  Congratulation on completing this challenge. Excellent work! I see you have received some inredible feedback from @imadbg01. I have some suggestions regarding your solution if you don’t mind:

  • You can use <main> landmark to wrap the card and <footer> for the attribution. HTML5 landmark elements are used to improve navigation.

  • In my opinion, the alternate text is needed on this image. It should indicate where the Qr code navigate the user : like QR code to frontend mentor.

  CSS:

  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  • Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.

  Overall , your solution looks great. hopefully this feedback helps.

  Marked as helpful

  1
• 

  imad•3,330

  @imadvvPosted over 2 years ago

  This comment was deleted over 2 years ago

  1

  ---

  

  Israel John•150

  @IsraeljonPosted over 2 years ago

  Thanks

  0
• 

  Israel John•150

  @IsraeljonPosted over 2 years ago

  Thanks

  0