Frontend Mentor - QR code component with pure HTML5 and CSS3
Design comparison
Solution retrospective
I am writing README.md for the first time, would like to get a feedback on improvements if any.
Community feedback
- @NaveenGumastePosted almost 3 years ago
Hay ! Good Job Srikar Gunnam
These below mentioned tricks will help you remove any Accessibility Issues
-> Add
Main
tag after body like it should be your container. For 1st heading orh1
tag, use header tag and then inside the header put yourh1
orh2
etc . But use header tag only once in main heading element.Keep up the good work!
Marked as helpful0@srikargunnamPosted almost 3 years agoHi Naveen Gumaste, should i include both
Header
andFooter
inside theMain
tag?Thanks in advance 🙏
1@NaveenGumastePosted almost 3 years ago@srikargunnam you can & you can put it outside too..
Marked as helpful0 - Account deleted
Hi there 👋 Congratulate on finishing your project 🎉. You did a great job 🔨. Your readme is great. Everything is included
I give some suggestions that I hope help you take your project to the next level 📈. About your design there is additional space at bottom of the card, maybe you should fix it also
Happy coding ☕
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord