Frontend Mentor | QR code component, using position property

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Greetings Alexander. Congratulations for taking your first challenge. Your solution looks amazing, here is some things that you can have a look at:

  • the h1 element is considered important ahead of other headings , it should be the first heading element .
  • the fixed width of 300px caused the site to cut off some content in mobile devices , check the site at 320px (some mobile devices are about that size)
  • the attribution is not positioned well at all times , this is a result of using positioning such as fixed and absolute - you will need to use dev tools to check the positioning of elements as elements positioned with absolute does not always maintain there position.
  • Another option to use that i can recommend is the css flexbox

  Marked as helpful

  1

  ---

  

  Alexander•50

  @MrSoykaPosted over 2 years ago

  @ChamuMutezva Hi, thank for help, now i work on qr_code_v2. Now i'm using flexbox and i fix my html elements, also i'm using max-width: 300px.

  Can you check my fixes? Thank you.

  0