Frontend Mentor | QR code component using html and css

Community feedback

• 

  raya•2,870

  @rayaattaPosted 10 months ago

  helloMonika-2509👋, congratulations on completing your first FED challenge 🎉

  I have some suggestions you might find useful.

  1 Try to make your html more Semantic by wrapping the main page content inside a <main> tag . Replace <div class="container"> With <main class="container">. This changes nothing visually but Using it makes all the difference. Using semantic markup improves

  SEO

  And user experience (accessibility) for people using assistive technology such as screen readers.

  2 I noticed that you used h2 .since it is the only heading in the document you should replace it with <h1>.

  Here's a quick guide on how to use them:

  The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on. You can then style them in you css.

  Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document

  3 In order to make the solution look closer to the design replace #DCF2F1 with hsl(212, 45%, 89%) as the body`s background

  4 The qr code's alt attribute should not just have info that it is a qr code rather it should state where the qr leads i.e alt="qr code leading to frontendmentor.io

  I hope this helps 🙃 Your solution looks awesome Happy coding ✌️

  Marked as helpful

  0