Frontend Mentor - QR code component solution using Flexbox and Grid

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  Background 🌆:

  • You should not recreate the background, you used the image desktop-preview.jpg to create your solution, but that image is for decoration and is a nice way to present the challenge, for example, you can use it in your github README.

    You must use the images desktop-design.jpg and mobile-design.jpg to create your solution.

  HTML 🏷️:

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

  • You should not use inline-CSS because it is not a good practice. Instead, you should use an external stylesheet to style your page. By doing this, you will be able to have a better organization of your code and will be able to understand it better.

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  John Carruthers•310

  @techyjcPosted 11 months ago

  @MelvinAguilar Thank you, Melvin. I have been messing about with HTML & CSS since the mid 90's. I really enjoy exploring the CSS capabilities. I realised about the background after I finished. Although re-creating the design elements was an interesting test in itself. I didn't use semantic elements as I was just testing my own knowledge of CSS. I have used Semantic elements when designing proper pages (Although more for fun and not work.).

  Thanks again.

  0
• 

  John Carruthers•310

  @techyjcPosted 11 months ago

  Not sure I was supposed to recreate the background patterns... (Now commenting on my own work)...

  0