Design comparison
Solution retrospective
My first challenge on frontend mentor Feel free to commentπ
Community feedback
- @correlucasPosted over 2 years ago
Hello Anie! Welcome to the Frontend Mentor community!
I'm looking your solution right now and I can see you've done a great job wrapping up all the content inside the div container, consider use main instead of div to improve the semantics. I like that your card is flexible even in smaller screens situations. The only issue you should fix is the image that is stretching with wrong proportions.
I notice that you've added some properties to the image, but what cause the image stretch is that you add
width: 100%;
and a different size for theheight
-->height: 300px;
note that if you adddisplay: block;
to the image and you set width with 100% there's no need to set the height, by default this value come in automatic..img-box img { width: 100%; max-width: 300px; }
Hope it helps you and I want to see you around with more challenges! Keep coding!
Marked as helpful0@A-n-i-ePosted over 2 years ago@correlucas Thanks for the feedback! I have made the changes πβ The name's Anie by the way βπβ
1@correlucasPosted over 2 years ago@A-n-i-e Hey Anie, sorry if I wrote your name wrong π , wasn't on purpose. I'm happy that the tips worked for you. Congrats. π
I fixed my first comment, now your name is right β€
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord