Frontend Mentor - QR code component solution

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have one suggestion about your code that might interest you.

  • The issue with position fixed for the footer is that the text often overlaps the component on mobile devices. You have two options: 1) use a media query to solely remove the fixed position on mobile devices or, 2) since you are using flexbox, use margin: auto to relocate the footer to the bottom. e.g.:

    .product__card {
        margin: auto;
        . . .
    }
    
    .attribution {
        /* position: fixed; */
        /* bottom: 0.3rem; */
       text-align: center;
    }
    

    More info here

    But even so you will have the component a bit higher, that is inevitable without using position fixed or absolute. :(

  Happy coding!

  1

  ---

  

  TPpseudo•60

  @TPpseudoPosted almost 2 years ago

  @MelvinAguilar

  That's great. Thank you for the feedback!

  0