Frontend Mentor QR Code Component Project

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Youssef Magdy, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  1.Replace the <p> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

  2.Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

  3.Add <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  4.Use relative units like rem or em instead of px to have a better performance when your page content resizes on different screens and devices. REM and EM does not just apply to font size, but all sizes as well. To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Youssef Magdy•160

  @youssefmagdy21Posted about 2 years ago

  Thanks @correlucas, your suggestions are much appreciated🙏 i will make sure to keep in mind

  0

  

  Youssef Magdy•160

  @youssefmagdy21Posted about 2 years ago

  Hey again @correlucas

  I would like to thank you again for your feedback, your suggestions helped me improve my code. ⚡👍

  Please if you would like to, feel free to review the updated version. Your feedback would be very appreciated. 🙏

  1

  

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  @youssefmagdy21 Much better now! Keep it up

  1