Frontend Mentor - QR code component

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 8 months ago

  Hey @AysenAlpsln!

  Your solution is really impressive!

  I've got a couple of ideas (about how to use HTML better) that could make it even stronger:

  📌 First: Think about using <main> to wrap your main content instead of <div>.

  Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

  📌 Second: Consider employing <h1> to <h6> tags for headings rather than using <span>.

  When it comes to headings, HTML offers us a range of heading tags: from <h1> to <h6>.

  Here's a quick guide on how to use them:

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> is for the most important heading.
  • <h6> is for the least important heading.
  • Stick to just one <h1> per page – it should be the main title for the whole page.
  • And don't skip heading levels – start with <h1>, then use <h2>, and so on.

  It's more than just text size — it's about structuring your content effectively.

  These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.

  Hope that's helpful!

  Keep up the great work!

  0
• 

  Robert•40

  @RobertLikesCodingPosted 8 months ago

  Hey there Aysen!

  Great job! This is very close to the original 👍 I read you were struggling finding the right font-family. Have another look in the project folder. There is a style-guide in there that gives you the font-family.

  Another small improvement you could keep in mind for the next challenge is more semantic HTML tags. Instead of the span tags rather use h1 and p and maybe even mainfor the main div. It seems irrelevant for tiny challenges like this but I think it's good practice to do it even for small projects :)

  Hope this helped!

  0