Frontend Mentor QR Code Component (HTML+CSS)

Community feedback

• 

  Felipe•130

  @freefrozzteaPosted over 2 years ago

  Hi Apurva congratulations on finishing the challenge.

  I think that the font-family and font-size were not the most appropriate to resemble the final result I see the background cannot be seen and therefore the card component cannot be identified And I saw in the deploy that the box-shadow could not be applied. This is because the minimum amount of parameters is 3. These are offset-x | offset-y | colour. In your case you have 2. You can see more about this here https://developer.mozilla.org/es/docs/Web/CSS/box-shadow

  I hope this helps

  1
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="main-div"> instead of <div class="man-div">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
  • You can wrapper your attribution section in a footer tag to avoid accessibility issues.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  0