Frontend Mentor QR code component

Community feedback

• 

  Ahmed Mohamed 🇵🇸•310

  @ahmedafsaPosted 11 months ago

  Hello @njabulo-t, good job! just quick notes to enhance the code

  • I noticed that you've centered the card vertically using margin, which not consistently maintain the card at the center particularly when the screen size changes ,Here's a simple trick to ensure the element remains centered:

  .your-container-div /* or body */ {
    min-height: 100vh;
    display: flex;
    align-items: center;
    justify-content: center;
  }
  

  • Also consider enhancing accessibility by integrating Semantic Elements such as <main>, <section>, or <article> into your code.

  0

  ---

  

  Njabulo•60

  @njabulo-tPosted 11 months ago

  Thank you for the feedback @ahmedafsa!

  0