Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Frontend Mentor QR code component

Njabulo 60

@njabulo-t

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@ahmedafsa

Posted

Hello @njabulo-t, good job! just quick notes to enhance the code

  • I noticed that you've centered the card vertically using margin, which not consistently maintain the card at the center particularly when the screen size changes ,Here's a simple trick to ensure the element remains centered:
.your-container-div /* or body */ {
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
}
  • Also consider enhancing accessibility by integrating Semantic Elements such as <main>, <section>, or <article> into your code.
0

Njabulo 60

@njabulo-t

Posted

Thank you for the feedback @ahmedafsa!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord