front-end mentor QR code component exercise

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • To properly center your content to your page, you will want to add the following to your body element (this method uses CSS Flex):

  body {
      min-height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
  
  }
  

  More Info:📚

  [Centering in CSS][https://moderncss.dev/complete-guide-to-centering-in-css/]

  • Change width to max-width in your component’s container to make it responsive.

  • The alt tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • Change width to max-width: 100% in your image to make it responsive.

  • The "Improve your front-end skill by building projects" needs to wrapped in an heading element.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  0