Frontend Mentor QR code component Darioriverosp

Community feedback

• 

  P

  Darrick Fauvel•490

  @DarrickFauvelPosted over 2 years ago

  Hi @darioriverosp, 👋

  Congratulations on posting your first solution! 🥳

  To fix the accessibility issues in the accessibility report (above ⬆️), you need to use at least one semantic html element. I would suggest wrapping your .card element with a <main></main> element. Also, you can do the same with <footer></footer> around the .attribution element.

  I would also recommend moving the .container to inside these "landmarks". Try something like this:

  <main>
      <div class="container">
        <div class="card"></div>
      </div>
  </main>
  
  <footer>
      <div class="container">
        <div class="attribution"></div>
      </div>
  </footer>
  

  I hope this is helpful. 😊

  Marked as helpful

  0