Frontend Mentor QR Code Component Challenge

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div class="qr-code-card"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Samuel Oluwadusi•60

  @iamadrenalinPosted over 1 year ago

  Thank you for leaving this feedback @0xAbdulKhalid I’ll surely implement this corrections

  0
• 

  Brandon J. Wells•30

  @dev-bjwellsPosted over 1 year ago

  It looks like you are off to a great start Dusi.

  The only suggestion I have is to take a closer look at the design provided by Frontend Mentor. If you look closely you will see that the width is a little smaller and there is a slight box shadow to the main element that seems to be missing from your proof of concept.

  Marked as helpful

  0

  ---

  

  Samuel Oluwadusi•60

  @iamadrenalinPosted over 1 year ago

  Thank you for leaving this feedback @dev-bjwells I’ll make sure I get back to fix all that 🙏❤️

  0