Frontend Mentor | QR code component

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • In order to fix the accessibility issues, you need to replace <div class="container"> with the <main> tag and <div class="attribution"> with the <footer> tag. :) You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

  • Another issue is that your <img> tag should include "alt" = attribute.

  • Finally, each main content needs to start with an h1 element. Your accessibility report states the need for one main landmark. So, you need to use a <h1> element in the <main> tag instead of using <h2>. You can replace your <h2>Improve your front-end skills by building projects</h2> elements with the <h1>Improve your front-end skills by building projects</h1> element.

  Hope I am helpful. :)

  Marked as helpful

  1

  ---

  

  Mustapha62996•80

  @Mustapha62996Posted over 1 year ago

  @ecemgo I appreciate the feedback. I would do something about it

  1

  

  Mustapha62996•80

  @Mustapha62996Posted over 1 year ago

  @ecemgo I have made the necessary changes. Thanks again by the way. Your comment has made me realize the importance of Semantic HTML

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @Mustapha62996 I'm happy to help. Happy coding! :)

  1