Frontend Mentor | QR code component

Community feedback

• 

  Oscar Bocanegra•235

  @obocanegra-devPosted over 1 year ago

  Congratulations on taking the plunge and tackling your first Frontend Mentor challenge! It looks great, and you've done a fantastic job.

  I have a few suggestions to enhance your work:

  Instead of writing CSS directly in your HTML, I recommend creating a separate stylesheet file and linking it to your HTML. This will help keep your code organized and make it easier to manage and update your styles.

  Consider using semantic elements rather than generic <div>s. Semantic elements like <header>, <nav>, <main>, and <footer> add meaning and structure to your HTML, improving accessibility and search engine optimization.

  For the QR code image, it would be helpful to use a more descriptive alt attribute, such as "QR code to Frontend Mentor website." This provides better context for screen readers and improves the accessibility of your site.

  Remember that font sizes should never be specified in pixels. It's better to use relative units like rem or em. This ensures that your font sizes are responsive and adapt well to different devices and user preferences.

  Keep up the excellent work, and don't hesitate to explore more challenges on Frontend Mentor to further enhance your skills! 🎉💪

  If you have any questions or need further assistance, feel free to ask. Good luck with your future projects! 🚀✨

  Warm regards, Oscar

  0